[PATCH 2/57][Arm][GAS] Add support for MVE instructions: vpst, vadd, vsub and vabd

Nick Clifton nickc@redhat.com
Thu May 2 10:56:00 GMT 2019


Hi Andre,

> This patch adds most of the framework used by the rest of the GAS patches for MVE.

I noticed that this function:

> +static int
> +check_simd_pred_availability (int fp, unsigned check)

returns an integer value, but it is only ever used in boolean
tests.  IMHO it should either have a bfd_boolean return type,
or else an enum with the return values having textual names to
indicate their meaning.

I also saw that in do_neon_logic() there is a test against 
the function returning FAIL:

      if (rs == NS_QQQ
	  && check_simd_pred_availability (0, NEON_CHECK_ARCH | NEON_CHECK_CC)
	  == FAIL)

But FAIL is not one of the values explicitly returned by 
check_simd_pred_availability()....

Cheers
  Nick




More information about the Binutils mailing list