[PATCH] x86: drop Vec_Imm4

[H.J. Lu]

On Fri, Jun 28, 2019 at 8:56 AM Jan Beulich <JBeulich@suse.com> wrote:
>
> It is pretty wasteful to have a per-operand flag which is used in
> exactly 4 cases. It can be relatively easily replaced, and by doing so
> I've actually found some dead code to remove at the same time (there's
> no case of ImmExt set at the same time as Vec_Imm4).
>
>
> gas/
> 2019-06-28  Jan Beulich  <jbeulich@suse.com>
>
>         * config/tc-i386.c (vec_imm4): Delete.
>         (VEX_check_operands): Replace Vec_Imm4 check by CpuXOP with five
>         operands one.  Clear Imm<N> by different means.
>         (build_modrm_byte): Adjust comment.  Remove dead code.  Add and
>         adjust assertions.
>
> opcodes/
> 2019-06-28  Jan Beulich  <jbeulich@suse.com>
>
>         * opcodes/i386-gen.c (operand_type_init): Remove
>         OPERAND_TYPE_VEC_IMM4 entry.
>         (operand_types): Remove Vec_Imm4.
>         * opcodes/i386-opc.h (Vec_Imm4): Delete.
>         (union i386_operand_type): Remove vec_imm4.
>         * i386-opc.tbl (vpermil2pd, vpermil2ps): Remove Vec_Imm4.
>         * opcodes/i386-init.h, i386-tbl.h: Re-generate.

OK.

> ---
> Obviously (I think) this goes on top of everything still pending
> approval.
>

Which ones are still pending?

Thanks.

-- 
H.J.