[PATCH] MIPS support for GNU hash

Nick Clifton nickc@redhat.com
Fri Jun 28 11:08:00 GMT 2019


Hi Mihailo,

> It proposed a new section (.gnu.xhash) and related dynamic tag
> (DT_GNU_XHASH).

I get the impression that this section, and tag, are MIPS specific.
If so then it may be better to include that in the names,  ie .mips.xhash
and DT_MIPS_XHASH.  If, on the other hand, you are intending for this
feature to have a wider appeal, then it would be worth proposing the
changes to the ELF standard committee.

Presumably you have tested this patch for thet target MIPS architecture(s).
Have you also made sure that it does not introduce any problems for other
architectures ?  Have you tried building a toolchain configured with 
--enable-targets=all ?

The patch itself looks fine to me, so my only real worry is the issue of
the names for the new section/tags.

Cheers
  Nick



More information about the Binutils mailing list