[PATCH] objdump: avoid shadowing a libiberty symbol

[Hans-Peter Nilsson]

On Tue, 25 Jun 2019, Nick Alcock wrote:
> On 25 Jun 2019, Jan Beulich verbalised:
>
> >>>> On 25.06.19 at 10:03, <amodra@gmail.com> wrote:
> >> On Tue, Jun 25, 2019 at 12:53:52AM -0600, Jan Beulich wrote:
> >>> Hmm, yes, fine with me. Will switch. I'd nevertheless hope I could get
> >>> approval to commit this without having to send a v2.
> >>
> >> Sure, go ahead.
> >
> > Thanks; I've extended this to the very similar readelf change as well,
> > but not to the slightly more different bfd/elf-properties.c and
> > ld/plugin.c ones.
>
> I was just about to suggest that you do exactly that. Thank you!
> (The mystery is why I didn't see this warning at any time. Different GCC
> version, perhaps?)

One version where you can see this is gcc-4.3.0. (Yes, I saw it
too, just didn't get around to do the legwork, so thanks Jan.)

The warning is removed from later gcc-versions, IIRC because it
was deemed incorrect, or removed as undesirable from -W, -Wall
or something like that.  That of course is not the same as (not)
actively avoiding the warning for compatibility reasons.

brgds, H-P