[PATCH] objdump: avoid shadowing a libiberty symbol

Jan Beulich JBeulich@suse.com
Tue Jun 25 06:54:00 GMT 2019


>>> On 24.06.19 at 21:31, <nick.alcock@oracle.com> wrote:
> On 24 Jun 2019, Jan Beulich outgrape:
>> --- a/binutils/objdump.c
>> +++ b/binutils/objdump.c
>> @@ -3207,10 +3207,10 @@ static char *
>>  dump_ctf_indent_lines (ctf_sect_names_t sect ATTRIBUTE_UNUSED,
>>  		       char *s, void *arg)
>>  {
>> -  char *spaces = arg;
>> +  char *spcs = arg;
> 
> Hm. "blanks" might be a better name?

Hmm, yes, fine with me. Will switch. I'd nevertheless hope I could get
approval to commit this without having to send a v2.

Jan




More information about the Binutils mailing list