RFC: Make dotnet assemblies test more robust

Omair Majid omajid@redhat.com
Thu Jul 25 22:57:00 GMT 2019

Hi Nick,

Nick Clifton <nickc@redhat.com> writes:

> I think that what we need to do is to extend gentestdlls.c so that
> it generates a normal x86 PE dll file as well.  Then the test can
> be extended to check this file first.  If the target objdump is
> able to parse this file, then it should be able to parse the other
> two files as well.  If it cannot then there is an error.  (Actually
> 32-bit PE toolchains may only be able to parse one of the new .NET
> PE dlls).

Thanks for the idea! How does the attached patch look?


2019-07-25  Omair Majid  <omajid@redhat.com>

	* testsuite/binutils-all/objdump.exp
	(test_objdump_dotnet_assemblies): Fix test to distinguish errors
	in parsing simple pei-i386 and pei-x86-64 vs parsing the newly
	introduced machine types.
	* testsuite/gentestdlls.c (write_simple_dll): New function.
	(main): Generate simple and Linux-specific variants of pei-i386
	and pei-x86-64 files so both can be used by tests.

PGP Key: B157A9F0 (http://pgp.mit.edu/)
Fingerprint = 9DB5 2F0B FD3E C239 E108  E7BD DF99 7AF8 B157 A9F0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-objdump-PEI-tests-a-little-more-robust-portable.patch
Type: text/x-patch
Size: 6223 bytes
Desc: patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20190725/520ccff5/attachment.bin>

More information about the Binutils mailing list