[PATCH 2/2] RISC-V: Merge ELF attribute for ld

Jim Wilson jimw@sifive.com
Tue Jan 15 02:00:00 GMT 2019


On Wed, Jan 9, 2019 at 12:28 PM Jim Wilson <jimw@sifive.com> wrote:
> On Wed, Jan 9, 2019 at 5:47 AM Kito Cheng <kito.cheng@gmail.com> wrote:
> > This is version 2 patch of implement the RISC-V ELF attribute merge.

This looks good.  It fixes the testsuite failures I had with only the
other two patches applied.

I noticed one place in riscv_merge_non_std_and_sv_ext where you still
have a line that ends with an open paren, but that is a minor style
issue.

I found it interesting that now that we use standard numbering for
attributes and standard code for parsing them, we can't have a zero
value Tag_RISCV_unaligned_access attribute anymore, as the standard
code filters out attributes with default values.  That looks OK
though, I don't think it will be a problem.

This is OK to go in once the other two patches are in.

Jim



More information about the Binutils mailing list