[Patch] [binutils][testsuite] Allow multiple lines of "as" in testsuite.
Matthew Malcomson
Matthew.Malcomson@arm.com
Thu Feb 21 14:50:00 GMT 2019
> Hi Matthew,
>
>> Each line is used as a set of flags, and the tests are ran against the output
>> of the assembler with each set.
>> Each line of assembler is treated as another set of tests (as if the test file
>> were duplicated but with a different #as: line).
>
Hi Nick, thanks for taking a look.
> Presumably it is not possible to make the DUMPPROG conditional upon the particular
> test being run, nor is it possible to make the regexp expressions conditional either ?
> (I am not complaining about this, but I think that this should be made clear in
> the comments that accompany the description of the AS option.
>
Yes this is correct.
> What happens if the SOURCE option is used with a set of flags of its own ? Are
> these flags combined with the flags for each of the AS options, or do they override
> them ? If they are combined, which set of flags comes first on the command line ?
>
The extra flags for the SOURCE option are appended to the flags for each of the
AS options, this is to maintain the current behaviour for just one AS option.
> If the LD or OBJCOPY options are also present in the .d file will these be run
> multiple times as well, once for each AS line ?
>
Yes, they would be run multiple times.
> On the whole however I would have to say that I like the idea of the patch. I
> just think that it needs a few more comments to make things clearer.
>
> Cheers
> Nick
>
Great, would the attached extra comments be OK?
Cheers,
Matthew
############ Attachment also inlined for easy reply/reading ###########
diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index 8c6f7ff..a501cf4 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -525,6 +525,11 @@ if ![string length [info proc prune_warnings]] {
# options in the "source" directives. See below.
# Multiple instances of this directive tells run_dump_test to run the test
# multiple times -- one time with each set of flags provided.
+# Each instance will run exactly as a file with a single "as" line, it is
+# not possible to condition any behaviour on which set of "as" flags is
+# used. That means that the "source" specific options are appended to
+# the "as" flags for their corresponding files, and any extra processing
+# (e.g. with "ld" and "objcopy") is repeated for each test.
#
# ld: FLAGS
# Link assembled files using FLAGS, in the order of the "source"
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: extra-comments.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20190221/d6e10d1c/attachment.ksh>
More information about the Binutils
mailing list