[PATCH 2/2] binutils: Add new GNU format mode to `size` utility
Andrew Burgess
andrew.burgess@embecosm.com
Fri Feb 8 11:10:00 GMT 2019
* Nick Clifton <nickc@redhat.com> [2019-02-07 14:05:11 +0000]:
1;5004;0c
> Hi Andrew,
>
> > binutils/ChangeLog:
> >
> > * size.c (berkeley_format): Delete.
> > (enum output_format): New enum.
> > (selected_output_format): New variable.
> > (usage): Update to mention GNU format.
> > (main): Update to extract options, and select format as needed.
> > Handle GNU format where needed.
> > (berkeley_sum): Renamed to...
> > (berkeley_or_gnu_sum): ...this, and updated to handle both formats.
> > (berkeley_format): Renamed to...
> > (berkeley_or_gnu_format): ...this, and updated to handle both
> > formats.
> > (print_sizes): Handle GNU format.
> > * doc/binutils.texi (size): Document new GNU format.
> > * testsuite/binutils-all/size.exp: Add test of extended
> > functionality.
> > * NEWS: Mention new functionality.
>
> Approved - please apply.
>
> There is no need to change the option name. Noone objected and I kind
> of like it, so lets keep it.
>
> > +Berkeley's. Alternatively, you can choose GNU format output (using @option{-G},
>
> Minor possible grammar nit: I wonder if the above sentance fragment ought
> to read:
>
> ...you can choose the GNU format output...
>
> (Ie adding in the word "the"). I am not insisting on this however, so the
> choice is up to you.
Thanks for the review, pushed with the fix you suggested.
Thanks,
Andrew
More information about the Binutils
mailing list