[PATCH Gold] Recognize clang-style crtbegin and crtend files
augustine.sterling@gmail.com
augustine.sterling@gmail.com
Mon Dec 30 17:33:00 GMT 2019
On Fri, Dec 27, 2019 at 4:50 PM Cary Coutant <ccoutant@gmail.com> wrote:
> By removing this, you're allowing the "-<target-name>" part on
> gcc-style filenames as well as clang-style. Unless you need to match
> that part even without the "clang_rt." prefix, I'd prefer to keep the
> stricter matching for gcc-style filenames. And it might be a good idea
> to at least check for the "-" before the target name. We just want to
> minimize the odds of accidentally matching a user-supplied object
> file.
Thanks for the review.
Enclosed is a patch that handles clang-style names completely
separately, and also
checks for the "-" before the target name.
> (I really wish there were a better way to handle these sections.
+1
> I
> hope you need this only to support section sorting, and not for the
> special treatment of .ctors and .dtors sections, which is a legacy you
> shouldn't be saddled with in clang.)
Unfortunately, we are saddled with this for certain legacy situations,
even with clang. I
wish it weren't so as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gold.patch
Type: text/x-patch
Size: 1967 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20191230/36de8f97/attachment.bin>
More information about the Binutils
mailing list