Make bfd_get_8 return a bfd_vma like other bfd_get_* functions
Alan Modra
amodra@gmail.com
Wed Dec 11 11:14:00 GMT 2019
And similarly for bfd_get_signed_8.
bfd/
* libbfd.c (bfd_get_8): Return a bfd_vma.
(bfd_get_signed_8): Return a bfd_signed_vma.
* bfd-in2.h: Regenerate.
binutils/
* od-xcoff.c (dump_dumpx_core): Adjust for bfd_h_get_8 change.
diff --git a/bfd/libbfd.c b/bfd/libbfd.c
index 6ff7172a0f..3a3e523bcc 100644
--- a/bfd/libbfd.c
+++ b/bfd/libbfd.c
@@ -449,9 +449,9 @@ DESCRIPTION
.#define bfd_put_signed_8 \
. bfd_put_8
.#define bfd_get_8(abfd, ptr) \
-. (*(const unsigned char *) (ptr) & 0xff)
+. ((bfd_vma) *(const unsigned char *) (ptr) & 0xff)
.#define bfd_get_signed_8(abfd, ptr) \
-. (((*(const unsigned char *) (ptr) & 0xff) ^ 0x80) - 0x80)
+. ((((bfd_signed_vma) *(const unsigned char *) (ptr) & 0xff) ^ 0x80) - 0x80)
.
.#define bfd_put_16(abfd, val, ptr) \
. BFD_SEND (abfd, bfd_putx16, ((val),(ptr)))
diff --git a/binutils/od-xcoff.c b/binutils/od-xcoff.c
index e5566bc9a7..7eb0c297c5 100644
--- a/binutils/od-xcoff.c
+++ b/binutils/od-xcoff.c
@@ -1680,8 +1680,10 @@ dump_dumpx_core (bfd *abfd, struct external_core_dumpx *hdr)
{
if (options[OPT_FILE_HEADER].selected)
{
- printf (" signal: %u\n", bfd_h_get_8 (abfd, hdr->c_signo));
- printf (" flags: 0x%02x\n", bfd_h_get_8 (abfd, hdr->c_flag));
+ printf (" signal: %u\n",
+ (unsigned) bfd_h_get_8 (abfd, hdr->c_signo));
+ printf (" flags: 0x%02x\n",
+ (unsigned) bfd_h_get_8 (abfd, hdr->c_flag));
printf (" entries: %u\n",
(unsigned) bfd_h_get_16 (abfd, hdr->c_entries));
#ifdef BFD64
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list