ubsan: s12z: left shift cannot be represented in type 'int'

Alan Modra amodra@gmail.com
Wed Dec 11 00:58:00 GMT 2019


	* s12z-opc.c (z_decode_signed_value): Avoid signed overflow.

diff --git a/opcodes/s12z-opc.c b/opcodes/s12z-opc.c
index 3e0c0e0582..044c72a21c 100644
--- a/opcodes/s12z-opc.c
+++ b/opcodes/s12z-opc.c
@@ -410,9 +410,7 @@ z_decode_signed_value (struct mem_read_abstraction_base *mra, int offset,
   int i;
   uint32_t value = 0;
   for (i = 0; i < size; ++i)
-    {
-      value |= buffer[i] << (8 * (size - i - 1));
-    }
+    value = (value << 8) | buffer[i];
 
   if (buffer[0] & 0x80)
     {

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list