[PATCH] x86-64: accept 64-bit LFS/LGS/LSS forms with suffix or operand size specifier
H.J. Lu
hjl.tools@gmail.com
Tue Dec 3 17:52:00 GMT 2019
On Fri, Nov 29, 2019 at 12:27 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> Since we accept these without suffix / operand size specifier, we should
> also do so with one. (The fact that we unilaterally accept these, other
> than far branches, rather than limiting them to Intel64 mode, will be
> taken care of later on.)
>
> Also take the opportunity and make sure "lfs <reg>, tbyte ptr <mem>"
> et al get rejected outside of 64-bit mode. This became broken by
> dc2be329b950 ("i386: Only check suffix in instruction mnemonic").
> Furthermore cover lgdt et al in the Intel syntax handling as well, which
> continued to work after said commit just by coincidence.
>
> gas/
> 2019-11-XX Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386-intel.c (i386_intel_operand): Handle LFS et al
> as well as LGDT at al when processing O_tbyte_ptr.
> * testsuite/gas/i386/intelbad.s: Add LDS et al cases.
> * testsuite/gas/i386/x86-64-intel64.s,
> * testsuite/gas/i386/x86-64-opcode.s: Add LFS et al cases.
> * testsuite/gas/i386/ilp32/x86-64-intel64.d: Add -mintel64
> command line option and fold expectations with parent dir test.
> * testsuite/gas/i386/x86-64-intel64.d: Add -mintel64 command
> line option and adjust expectations.
> * testsuite/gas/i386/intelbad.l,
> testsuite/gas/i386/x86-64-opcode.d: Adjust expectations.
>
> opcodes/
> 2019-11-XX Jan Beulich <jbeulich@suse.com>
>
> * i386-opc.tbl (lfs, lgs, lss): Drop No_qSuf.
> * i386-tbl.h: Re-generate.
>
OK.
Thanks.
--
H.J.
More information about the Binutils
mailing list