[PATCH] xtensa: bfd: add special case to loop alignment check

Max Filippov jcmvbkbc@gmail.com
Thu Aug 1 18:21:00 GMT 2019


On Wed, Jul 31, 2019 at 11:20 AM augustine.sterling@gmail.com
<augustine.sterling@gmail.com> wrote:
>
> On Wed, Jul 31, 2019 at 12:22 AM Max Filippov <jcmvbkbc@gmail.com> wrote:
> >
> > check_loop_aligned is used during link time relaxation to only allow
> > transformations that don't violate loop body alignment requirements.
> > Assembler can relax loops that have too long body by adding instructions
> > between the loop instruction and the loop body. check_loop_aligned must
> > check alignment of the first instruction of the actual loop body.
> > Detect loop / rsr.lend / wsr.lbeg sequence used in assembly time
> > relaxation and adjust alignment check when it's detected.
>
> Approved.

Applied to master, thanks.

> I'm surprised no one has noticed this until now.

It was broken by the recent change to long loop relaxation, before that
the whole such loops were marked as non-transformable.

-- 
Thanks.
-- Max



More information about the Binutils mailing list