[PATCH 1/2] [MIPS] Apply ASE information for the selected processor

Paul Hua paul.hua.gm@gmail.com
Sat Apr 13 08:32:00 GMT 2019


Hi, Faraz,

Just small comments.

>    /* Set up the current options.  These may change throughout assembly.  */
>    mips_opts = file_mips_opts;
> @@ -15189,6 +15193,7 @@ mips_after_parse_args (void)
>
>    file_mips_opts.arch = arch_info->cpu;
>    file_mips_opts.isa = arch_info->isa;
> +  file_mips_opts.init_ase = arch_info->ase;
>
>    /* Set up initial mips_opts state.  */
>    mips_opts = file_mips_opts;
> @@ -16559,6 +16564,7 @@ parse_code_option (char * name)
>               mips_opts.arch = p->cpu;
>               mips_opts.isa = p->isa;
>               isa_set = TRUE;
> +             mips_opts.init_ase = p->ase;
>             }
>         }

Mentions this in changelog.

>        else if (strncmp (name, "mips", 4) == 0)
> @@ -16573,6 +16579,7 @@ parse_code_option (char * name)
>               mips_opts.arch = p->cpu;
>               mips_opts.isa = p->isa;
>               isa_set = TRUE;
> +             mips_opts.init_ase = p->ase;
>             }
>         }
>        else

same as above.

> @@ -16646,6 +16653,7 @@ s_mipsset (int x ATTRIBUTE_UNUSED)
>      {
>        mips_opts.isa = file_mips_opts.isa;
>        mips_opts.arch = file_mips_opts.arch;
> +      mips_opts.init_ase = file_mips_opts.init_ase;
>        mips_opts.gp = file_mips_opts.gp;
>        mips_opts.fp = file_mips_opts.fp;
>      }

Same.

After added those in changelog, apply to reop.



More information about the Binutils mailing list