Disable R_X86_64_PLT32 generation as branch marker on Solaris/x86

[Rainer Orth]

Hi H.J.,

> On Wed, Apr 3, 2019 at 7:50 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>
>> Hi H.J.,
>>
>> >> > Please create a subdirectory, solaris, with copies of those tests and
>> >> > skip original tests for Solaris targets so that the original tests can be
>> >> > updated without affecting Solaris targets.
>> >>
>> >> How would this help?  Do you want me to create copies of the affected .s
>> >> files and move the *-solaris.d files both to that solaris subdirectory?
>> >
>> > Yes.
>> >
>> >> If gas produces different output for identical input, the solaris .d
>> >> files have to be changed anyway, irrespective of their location.
>> >
>> > Not necessarily.  Initially both inputs are the same.  But it may
>> > change over time.
>>
>> True, but in the overwhelming majority of cases, gas will produce the
>> same output on both Linux and Solaris.  When we stay with only one set
>> of .s files, one immediately notices the need to adapt the Solaris .d
>> files the next time make check is run, without any impact on other
>> targets.  We can still fork the inputs should it really becomes
>> necessary at some point.
>
> You can initially use "#source:" in solaris directory and make a
> copy later when needed.  I want the original tests not tied to Solaris.

here's what I came up with.  I'm not too pleased with the result, though:
unlike the previous version with the optional -solaris suffix for the .d
files, you loose the obvious connection between the tests in the i386
directory and the i386/solaris one.  I tried to use an optional solaris/
prefix in the test names instead, but this failed since run_dump_test
considers every test name with a slash in it to be an absolute
filename.

Anyway, tested without regressions on amd64-pc-solaris2.11 and
x86_64-pc-linux-gnu.  Ok for master?

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2019-03-06  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/tc-i386.c (need_plt32_p) [TE_SOLARIS]: Return FALSE.
	* testsuite/gas/i386/solaris/solaris.exp: New driver.
	* testsuite/gas/i386/solaris/reloc64.d,
	testsuite/gas/i386/solaris/x86-64-jump.d,
	testsuite/gas/i386/solaris/x86-64-mpx-branch-1.d,
	testsuite/gas/i386/solaris/x86-64-mpx-branch-2.d,
	testsuite/gas/i386/solaris/x86-64-nop-3.d,
	testsuite/gas/i386/solaris/x86-64-nop-4.d,
	testsuite/gas/i386/solaris/x86-64-nop-5.d,
	testsuite/gas/i386/solaris/x86-64-relax-2.d,
	testsuite/gas/i386/solaris/x86-64-relax-3.d: New tests.
	* testsuite/gas/i386/reloc64.d,
	testsuite/gas/i386/x86-64-jump.d,
	testsuite/gas/i386/x86-64-mpx-branch-1.d,
	testsuite/gas/i386/x86-64-mpx-branch-2.d,
	testsuite/gas/i386/x86-64-nop-3.d,
	testsuite/gas/i386/x86-64-nop-4.d,
	testsuite/gas/i386/x86-64-nop-5.d,
	testsuite/gas/i386/x86-64-relax-2.d,
	testsuite/gas/i386/x86-64-relax-3.d: Skip on *-*-solaris*.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gas-solx64-no-r_amd64_plt32.patch
Type: text/x-patch
Size: 19723 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20190409/266e763c/attachment.bin>