[PATCH] csky-opc.h: Initialize fields of last array elements

[Simon Marchi]

On 2018-09-20 07:40 PM, Alan Modra wrote:
> On Thu, Sep 20, 2018 at 08:23:19PM +0000, Simon Marchi wrote:
>> clang gives these errors:
>>
>> In file included from /Users/simark/src/binutils-gdb/opcodes/csky-dis.c:30:
>> /Users/simark/src/binutils-gdb/opcodes/csky-opc.h:2330:8: error: missing field 'transfer' initializer [-Werror,-Wmissing-field-initializers]
>>   {NULL}
>>        ^
>> /Users/simark/src/binutils-gdb/opcodes/csky-opc.h:8126:10: error: missing field 'transfer' initializer [-Werror,-Wmissing-field-initializers]
>>     {NULL}
>>          ^
>>
>> They go away when we Initialize all fields.  I noticed there used to be some
>> files built with -Wno-missing-field-initializers, but it's not the case
>> anymore, since commit e7ae278d0474ab84ba3b1ee932a19e83616ddacc.  There is still
>> a NO_WMISSING_FIELD_INITIALIZERS variable defined in the Makefile, but it's
>> unused, so I removed it to avoid further confusion.
>>
>> opcodes/ChangeLog:
>>
>> 	* Makefile.am: Remove NO_WMISSING_FIELD_INITIALIZERS.
>> 	* Makefile.in: Re-generate.
>> 	* aclocal.m4: Re-generate.
>> 	* configure: Re-generate.
>> 	* configure.ac: Remove check for -Wno-missing-field-initializers.
>> 	* csky-opc.h (csky_v1_opcodes): Initialize all fields of last element.
>> 	(csky_v2_opcodes): Likewise.
> 
> OK.
> 


Thanks, pushed.

Simon