[PATCH] 2.31 breaks build of 'gold' for x86_64-w64-mingw32

Alexey Neyman stilor@att.net
Tue Oct 30 05:10:00 GMT 2018



On 10/23/2018 06:03 PM, Cary Coutant wrote:
>> Patch attached. Replacement code for mkdtemp stolen from
>> binutils/bucomm.c; link() call is just placed under an appropriate
>> ifdef, as the function already has a fallback (copying the file).
> +AC_CHECK_FUNCS(chsize mmap link)
> ..
>   AC_CHECK_FUNCS(mallinfo posix_fallocate fallocate readv sysconf times)
> +AC_CHECK_FUNC([mkdtemp],
> +              AC_DEFINE([HAVE_MKDTEMP], 1,
> +              [Define to 1 if you have the `mkdtemp' function.]))
>
> Is there a reason why you didn't just add mkdtemp to one of the
> AC_CHECK_FUNCS macros?
No specific reason, just copy-pasted from the same check in 
binutils/configure.ac.

Included into the AC_CHECK_FUNCS right above; updated patch attached.

Regards,
Alexey.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Restore-build-on-x86_64-w64-mingw32.patch
Type: text/x-patch
Size: 3922 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20181030/b0387b37/attachment.bin>


More information about the Binutils mailing list