[PATCH][Binutils][Arm] Fix disassembler crashing on -b binary when thumb file and thumb not forced.

Christophe Lyon christophe.lyon@linaro.org
Fri Oct 19 12:44:00 GMT 2018


Hi Tamar,


On Thu, 18 Oct 2018 at 18:18, Nick Clifton <nickc@redhat.com> wrote:
>
> Hi Tamar,
>
> > gas/ChangeLog:
> > 2018-10-17  Tamar Christina  <tamar.christina@arm.com>
> >
> >       * testsuite/gas/arm/undefined-insn-arm.d: New test.
> >       * testsuite/gas/arm/undefined-insn-thumb.d: New test.
> >       * testsuite/gas/arm/undefined-insn.s: New test.
> >
> > opcodes/ChangeLog:
> > 2018-10-17  Tamar Christina  <tamar.christina@arm.com>
> >
> >       * arm-dis.c (UNKNOWN_INSTRUCTION_32BIT): Format specifier for arm mode.
> >       (UNKNOWN_INSTRUCTION_16BIT): Format specifier for thumb mode.
> >       (print_insn_arm, print_insn_thumb16, print_insn_thumb32): Use them.
>
> Approved - please apply.
>
> Cheers
>   Nick
>
>
> PS.  Thank you for getting rid of some aborts.  Personally, I think that
> they are a bad thing to have in a library...


I've noticed regressions after your patch on arm-wince-pe:
FAIL: gas:Undefined binary printing in arm mode
FAIL: gas:Undefined binary printing in thumb mode

Christophe



More information about the Binutils mailing list