[PATCH][Binutils][Arm] Fix disassembler crashing on -b binary when thumb file and thumb not forced.

Tamar Christina tamar.christina@arm.com
Wed Oct 17 16:18:00 GMT 2018


Hi All,

The disassembler for Arm has some aborts in it in places it assumes can never
be reached.  Under normal circumstances they indeed cannot be reached because
the right options are selected from the ARM attributes in the ELF file.

However when disassembling with -b binary then if you do not get the options
right the disassembler just aborts.  This changes it so it just prints how it
was trying to interpret the instruction and prints UNKNOWN instructions next to it.

This way the user has an idea of what's going.

build on native hardware and regtested on
  arm-none-eabi, arm-none-eabi (64 bit host),
  arm-none-linux-gnueabihf, arm-none-linux-gnueabihf (64 bit host)

Cross-compiled and regtested on
  arm-none-eabi, armeb-none-eabi

and no issues.

Ok for master? and for backport to binutils-2.31?

Thanks,
Tamar

gas/ChangeLog:
2018-10-17  Tamar Christina  <tamar.christina@arm.com>

	* testsuite/gas/arm/undefined-insn-arm.d: New test.
	* testsuite/gas/arm/undefined-insn-thumb.d: New test.
	* testsuite/gas/arm/undefined-insn.s: New test.

opcodes/ChangeLog:
2018-10-17  Tamar Christina  <tamar.christina@arm.com>

	* arm-dis.c (UNKNOWN_INSTRUCTION_32BIT): Format specifier for arm mode.
	(UNKNOWN_INSTRUCTION_16BIT): Format specifier for thumb mode.
	(print_insn_arm, print_insn_thumb16, print_insn_thumb32): Use them.

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rb10084.patch
Type: text/x-diff
Size: 2617 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20181017/3d59b803/attachment.bin>


More information about the Binutils mailing list