[PATCH] [objcopy] Return a fatal error when --keep-global-symbol(s) is used with --globalize-symbols, since it is an error prone pattern.

Nick Clifton nickc@redhat.com
Thu Oct 11 10:44:00 GMT 2018


Hi Jordan,

  Thanks very much for the patch.  It is fine, and I have applied it
  to the binutils sources.  I did make a couple of additions:

  * I updated the documentation to mention that the two options should
    not be used together.

  * I added a test to the binutils testsuite to make sure that the
    error message is produced.

  * I created an entry in the binutils/ChangeLog file describing the 
    patch.

Cheers
  Nick

PS.  Since the patch was quite simple, I have treated it as "obvious"
which means that you do not need a FSF copyright assignment.  If 
however in the future you wish to contribute bigger patches - and I
hope that you will - then you will need a copyright assignment in
place.



More information about the Binutils mailing list