[PATCH 3/3] ELF: Add testcases for PR ld/23658

H.J. Lu hjl.tools@gmail.com
Wed Oct 3 20:38:00 GMT 2018


On Wed, Oct 3, 2018 at 9:26 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Wed, Oct 3, 2018 at 7:29 AM Nick Clifton <nickc@redhat.com> wrote:
> >
> > Hi H.J.
> >
> > >> Is the build-id note necessary ?  You could check note segment assignment
> > >> without it...
> > >
> > > This test checks if the .note.gnu.build-id section is properly handled.
> >
> > But you could easily have two tests.  One which checks that .note.gnu.build-id
> > is handled properly, but which will not run on targets which do not support the
> > generation of build-ids.  Then you could have a second test, which would run
> > for all (ELF) targets, which does not use --build-id, but which does still check
> > that similarly aligned notes are combined and placed into properly aligned segments.
>
> The reason why these targets are skipped is that they use generic
> linker, not ELF
> linker.  This test is irrelevant for these targets.
>

Since generic linker targets don't place SHT_NOTE sections as orphan, SHT_NOTE
sections aren't grouped nor sorted.  I am checking in this updated patch.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ELF-Add-testcases-for-PR-ld-23658.patch
Type: text/x-patch
Size: 6955 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20181003/5dd84200/attachment.bin>


More information about the Binutils mailing list