[PATCH gold/21066] Consider C++ exception handling metadata during ICF

Joshua Oreman oremanj@hudson-trading.com
Tue Oct 2 23:57:00 GMT 2018


Yes, I'd be happy to do so, I just wasn't familiar with the procedure.
Could you send me the relevant details off-list?

Thanks,
Josh

On Tue, Oct 2, 2018 at 4:35 PM Cary Coutant <ccoutant@gmail.com> wrote:

> > Two functions with the same code might not be combinable during ICF if
> > they have different C++ exception handling metadata. PR gold/21066
> > demonstrates this for the case where only the LSDA differs. New
> > optimizations in GCC 8 can also create cases where the code is
> > identical but the unwind tables differ; see gold/23482 for more
> > details. This patch extends ICF to consider a function's associated
> > FDE and CIE, including any relocations therein (e.g. to the LSDA),
> > when deciding whether two functions are identical or not.
>
> Thanks for the patch!
>
> Before I can review it, however, we need a copyright assignment on
> file with FSF. I looked, but didn't find one for you or your company.
> Would you be willing to assign the copyright to the Free Software
> Foundation? If so, I can send you the instructions for taking care of
> that.
>
> -cary
>



More information about the Binutils mailing list