[PATCH] RISC-V: Add missing c.unimp instruction.

Jim Wilson jimw@sifive.com
Fri Nov 30 03:43:00 GMT 2018


On Thu, Nov 29, 2018 at 6:44 PM Palmer Dabbelt <palmer@sifive.com> wrote:
> I agree that auditing the list isn't high priority, but that doesn't mean we
> should skip fixing the bugs that jump out.  I can send the patch if you want.

I'm finding your comments hard to parse, as there are too many mistakes here.

I agree that unimp is an alias for csrrw, but I think you are
unnecessarily sacrificing usability if you mark it as an alias.

> >> {"c.ebreak",   0, {"C", 0},   "",  MATCH_C_EBREAK, MASK_C_EBREAK, match_opcode, 0 },
> >
> > This one is explicitly listed in the ISA manual as an illegal instruction, so
> > it's correct to not be an alias.

c.ebreak is not an illegal instruction.  Maybe you meant c.unimp here?

Jim



More information about the Binutils mailing list