[PATCH] elf: Report property change when merging properties

[H.J. Lu]

On Thu, Nov 29, 2018 at 6:50 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Nov 27, 2018 at 4:35 AM Nick Clifton <nickc@redhat.com> wrote:
> >
> > Hi Guys,
> >
> > >>> Merging property 0xc0000002 in foo.o (0x1) and bar.o (None): removed
> > >>
> > >> To me this is a confusing message.  How about simply saying "Removed
> > >> property 0xc0000002 in foo.o (0x1)", and similarly for the other
> >
> > > This misses the crucial info that property 0xc0000002 is removed due to
> > > bar.o (None).
> >
> > Indeed - this was my motivation for requesting the patch in the first place.
> >
> > How about rewording the message as:
> >
> >   Property 0xc00000002 (0x1) found in foo.o but removed from final link because it is not found in bar.o
> >
> > A little bit more wordy perhaps, but I think that it explains what is going
> > on in clearer language.
> >
>
> How about this?
>
> Removed property 0xc0000002 to merge foo.o (0x1) and bar.o (not found)
>
>

Here is the updated patch with ld.texi change.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-elf-Report-property-change-when-merging-properties.patch
Type: text/x-patch
Size: 9369 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20181129/d1117230/attachment.bin>