[PATCH] x86: Don't remove empty x86 properties

Cary Coutant ccoutant@gmail.com
Tue Nov 27 20:07:00 GMT 2018


> > GNU_PROPERTY_X86_ISA_1_USED bits can be all zero when only
> > base x86 instructions are used.  Linker shouldn't remove properties
> > with zero bits.

Yet in another patch, you are removing properties:

> > To me this is a confusing message.  How about simply saying "Removed
> > property 0xc0000002 in foo.o (0x1)", and similarly for the other
> > messages where properties are removed.  If ld is removing them then it
> > isn't merging them.
>
> This misses the crucial info that property 0xc0000002 is removed due to
> bar.o (None).

You still haven't explained the difference between a missing property
and one that is all zeroes. Do you *really* think it's a good idea to
make a distinction?

> > > Where is this documented? How is a property consisting of all zeroes
> > > different from a missing property?

-cary



More information about the Binutils mailing list