[PATCH][GAS][MSP430] Improve NOP warnings/insertion behaviour around interrupt state changes

[Jozef Lawrynowicz]

On Tue, 27 Nov 2018 12:30:44 +0000
Nick Clifton <nickc@redhat.com> wrote:

> Approved and applied.

Hi Nick, 
Thanks for the review.

> > diff --git a/gas/config/tc-msp430.c b/gas/config/tc-msp430.c  
> [...]
> > @@ -2654,37 +2733,76 @@ msp430_operands (struct msp430_opcode_s * opcode, char * line)  
> [...]
> >  
> > -		  if (gen_interrupt_nops)
> > -		    /* Emit a NOP between interrupt enable/disable.
> > -		       See 1.3.4.1 of the MSP430x5xx User Guide.  */
> > -		    doit = TRUE;
> > -		  break;
> > -
> >  		case NOP_CHECK_CPU12:  
> 
> This deleted the "break" statement at the end of NOP_CHECK_INTERRUPT case.
> I assumed that your intent was not to fall through into the NOP_CHECK_CPU12
> case, so I restored the break statement.
> 

Ah yes, that was a mistake, thanks for fixing it.

Jozef