[PATCH][BINUTILS][AARCH64] Add support for pointer authentication B key

[Sam Tebbs]

On 11/21/18 12:45 PM, Nick Clifton wrote:

> Hi Sam,
>
>> Attached is a revised patch with the target hooks implemented and
>> target-specific definitions (pointer_auth_key etc.).
>>
>> bfd/
>>
>> 2018-11-20  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>       * elf-eh-frame.c (_bfd_elf_parse_eh_frame): Add check for 'B'.
>>
>> binutils/
>>
>> 2018-11-20  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>       * dwarf.c (read_cie): Add check for 'B'.
>>
>> gas/
>>
>> 2018-11-20  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>       * dw2gencfi.c (struct cie_entry): Add tc_cie_entry_extras invocation.
>>       (alloc_fde_entry): Add tc_fde_entry_init_extra invocation.
>>       (output_cie): Add tc_output_cie_extra invocation.
>>       (select_cie_for_fde): Add tc_cie_fde_equivalent_extra and
>> tc_cie_entry_init_extra
>>       invocation.
>>       (frch_cfi_data, cfa_save_data): Move to dwgencfi.h.
>>       * config/tc-aarch64.c (s_aarch64_cfi_b_key_frame): Declare.
>>       (md_pseudo_table): Add "cfi_b_key_frame".
>>       * config/tc-aarch64.h (tc_fde_entry_extras, tc_cie_entry_extras,
>>       tc_fde_entry_init_extra, tc_output_cie_extra,
>> tc_cie_fde_equivalent_extra,
>>       tc_cie_entry_init_extra): Define.
>>       * dw2gencfi.h (struct fde_entry): Add tc_fde_entry_extras invocation.
>>       (pointer_auth_key): Define.
>>       (frch_cfi_data, cfa_save_data): Move from dwgencfi.c.
>>
>> gas/doc/
>>
>> 2018-11-20  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>       * c-aarch64.texi (.cfi_b_key_frame): Add documentation.
> Note - changelog entries for gas/doc actually go into gas/ChangeLog...
>
>> gas/testsuite
>>
>> 2018-11-20  Sam Tebbs  <sam.tebbs@arm.com>
>>
>>       * gas/aarch64/(pac_ab_key.d, pac_ab_key.s): New file.
>>
> Likewise - this should be in gas/ChangeLog...

Ah I see. I assumed binutils used the same changelog format as GCC but 
will keep this in mind. Is there a script in binutils that is similar to 
GCC's contrib/mklog?

>
> Patch approved with updates to the changelog as mentioned above.  Please apply.
>
> Cheers
>    Nick

Thanks, I don't have commit rights so Ramana has agreed to commit it on 
my behalf.

Sam