[PATCH] [testsuite] Fix ld action in run_dump_test

[Thomas Preudhomme]

Hi Alan,

Sorry for the late reply. See
https://sourceware.org/ml/binutils/2018-10/msg00289.html. In this case
I'm testing that both GAS and objcopy are doing the right thing and it
made sense to have only one set of test to reduce duplication. It also
need to run objcopy twice (once to remove a section, once to check its
behavior without that section) and I don't think the ld tests allow
this, but the run_dump_test allow it if linking. I don't technically
need linking, it was just a convenient way to get objcopy to run
twice. I welcome any suggestion on how to do this in a better way. In
the meantime I've committed this patch as if the feature is there it
should be working IMO.

Best regards,

Thomas
On Mon, 29 Oct 2018 at 22:55, Alan Modra <amodra@gmail.com> wrote:
>
> On Fri, 26 Oct 2018 at 14:28, Thomas Preudhomme <thomas.preudhomme@linaro.org> wrote:
> > run_dump_test proposes an ld action but when trying to make use of it in
> > a gas test it gave me some Tcl error.
>
> I have to wonder why you are using ld in the gas testsuite (making a
> test of the linker which should perhaps be moved to the ld testsuite)?
>
> Anyway, patch is OK.
>
> --
> Alan Modra
> Australia Development Lab, IBM