[PATCH] Fix typo in Makefile.am to make it agree with Makefile.in.

Jim Wilson jimw@sifive.com
Sun May 6 15:21:00 GMT 2018


On Sun, May 6, 2018 at 5:44 AM, John Darrington
<john@darrington.wattle.id.au> wrote:
> What on earth are files such as Makefile.in,  configure, and many other
> generated files doing in the repository in the first place?

To make it easier for end users to build binutils sources.  To
regenerate Makefile.in, I had to build and install the specific
version of automake that is the same as the one used to build it in
the first place.  This is an unreasonable requirement for end users
who just want to build the sources.

> I suggest that all generated files are removed from the repo, (and a bootstrap
> script, or auxiallary Makefile be introduced to regenerate them).

There are already build rules for this.  Use --enable-maintainer-mode
when configuring binutils.

I can't support removing the generated files from the repo.  I think
that will cause more trouble than it will fix.  I also think that it
won't solve the problem.  The problem arose because Makefile.in was
accidentally edited instead of Makefile.am.  If Makefile.in is created
at build time, then you still have it in your tree, and you can still
accidentally edit it.  It only Makefile.am is checked in, then we
would not have noticed the inconsistency, and it would likely have
taken far longer to notice and fix the problem.  So having both
Makefile.am and Makefile.in helps to catch these kinds of errors.

Jim



More information about the Binutils mailing list