[PATCH] gold/testsuite: Fix bad regexp in split_x86_64.sh

Roland McGrath via binutils binutils@sourceware.org
Tue Mar 27 23:37:00 GMT 2018


.*+ is a nonsensical regexp.  It appears to work fine in GNU egrep, but not
in all other implementations.  I think the + was just a typo.

OK for trunk and 2.30?


Thanks,
Roland


gold/
2018-03-27  Roland McGrath  <mcgrathr@google.com>

	* testsuite/split_x86_64.sh: Fix bad regexp.

diff --git a/gold/testsuite/split_x86_64.sh b/gold/testsuite/split_x86_64.sh
index e436b51c176..98dc5c55a2e 100755
--- a/gold/testsuite/split_x86_64.sh
+++ b/gold/testsuite/split_x86_64.sh
@@ -2,7 +2,7 @@

 # split_x86_64.sh -- test -fstack-split for x86_64

-# Copyright (C) 2009-2017 Free Software Foundation, Inc.
+# Copyright (C) 2009-2018 Free Software Foundation, Inc.
 # Written by Ian Lance Taylor <iant@google.com>.

 # This file is part of gold.
@@ -38,7 +38,7 @@ nomatch()
   fi
 }

-match 'cmp.*+%fs:[^,]*,%rsp' split_x86_64_1.stdout
+match 'cmp.*%fs:[^,]*,%rsp' split_x86_64_1.stdout
 match 'callq.*__morestack>?$' split_x86_64_1.stdout
 match 'lea.*-0x200\(%rsp\),' split_x86_64_1.stdout



More information about the Binutils mailing list