Feature request: improved build-id generation

[Laura Abbott]

ArOn 03/16/2018 11:37 AM, Cary Coutant wrote:
>>> Then I'm stating my case poorly.  I want a way to inject additional
>>> data into the has computation.
>>
>> At one point, we proposed doing this via a linker- or assembler-oriented
>> extra "salt" parameter, which would be hashed into the buildid.  This
>> would most naturally be a n-v-r-a string, so the build is reproducible.
>> Such a salt could be naturally injected via an environment variable set
>> by rpmbuild.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1002341 (salt!)
>> https://bugzilla.redhat.com/show_bug.cgi?id=1550152 (life without salt)
> 
> I don't have a problem with adding a --build-id-salt="some arbitrary
> string" option, and I think "salt" is exactly the right term for this.
> I'd much prefer providing that than having you use a linker script.
> (I'm somewhat puzzled that you find the linker script option less
> objectionable than an object file with a note section.)
> 
> As Nick said earlier, it's not that we don't care about your feature
> request. I simply wanted to explore the options, and I gave you a
> couple of options that require no new features at all.
> 
> My other comments have been about the unnecessary conflating of a new
> option like --build-id-salt with the choice of hashing algorithm.
> 

At least in the kernel we already have the infrastructure for
customizations to linker scripts so it's fairly easy to expand on that.
I have a prototype which should work, I just need to clean it up
for review to see if it's feasible to merge vs. adding a --build-id-salt
option.

Thanks,
Laura


> -cary
>