[patches] Re: [PATCH] RISC-V: Add .insn support
Thu Mar 8 16:41:00 GMT 2018
Oops, I've removed 4 operand format support in this version, but I guess it
be useful when doing some ISA exploration. I'll restore that and named r4
format in next version.
and I don't support any floating point instruction for .insn directive yet,
one of reason to me is here
is no instruction format name defined in ISA spec.
On Thu, Mar 8, 2018 at 2:24 AM, Andrew Waterman <firstname.lastname@example.org> wrote:
> I think permitting 4-operand integer instructions is fine.
> On Wed, Mar 7, 2018 at 10:21 AM, Jim Wilson <email@example.com> wrote:
> > On Wed, Mar 7, 2018 at 2:04 AM, Andrew Waterman <firstname.lastname@example.org>
> >> Thanks for contributing this patch. I did not thoroughly review the
> >> code, but I like the approach. Jim or Palmer will probably follow up
> >> with additional comments.
> > I looked at the previous version of the patch a month or so ago, and
> > the only curious thing I noticed is that the 4-operand instruction
> > pattern has type I, but in the ISA these are only used for FP
> > instructions. I'm not sure if this can be fixed though, since we
> > don't have any category that covers all FP extensions: F, D, Q. Plus
> > someone might want to try using a 4-operand instruction with integer
> > operands so it is probably reasonable to allow that.
> > My schedule is very hectic at the moment, as I'm in the middle of
> > moving to a new home closer to work. I should be able to find time to
> > look at this new version of the patch sometime soon.
> > Jim
> You received this message because you are subscribed to the Google Groups
> "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to email@example.com.
> To post to this group, send email to firstname.lastname@example.org.
> Visit this group at https://groups.google.com/a/groups.riscv.org/group/
> To view this discussion on the web visit https://groups.google.com/a/
> For more options, visit https://groups.google.com/a/
More information about the Binutils