[PATCH] x86: Treat relocation against IFUNC symbol as FUNC

[H.J. Lu]

On Wed, Mar 7, 2018 at 7:04 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.
>
>>> Actually - thinking about it further ... why should it matter that it is a
>>> note section that is being relocated ?  Surely the same logic should apply
>>> to any ifunc-targeted relocation in a non-alloc section.  For example, I
>>> wonder if your patch would actually work for debug sections as well ?
>>> (Rather than the current option of just silently ignoring the reloc).
>>
>> GDB has special handling for IFUNC symbols which works well for the
>> current approach with debug sections.  Will such a change break GDB?
>
> Probably.  I did not know that GDB had such handling.
>
> OK, so apart from debug sections, is there any reason not to treat ifunc
> targeted relocs in non-alloc sections as if they were targeted at the func
> instead ?  IE not just for note sections, but for all non-alloc, non-debug
> sections ?

This is the first time we saw abort.  There are 2 ways to handle it, skip it
or treat it as FUNC.  We don't know which way is appropriate for the next
instance.  I prefer to keep my patch as is.

-- 
H.J.