[PATCH 2/4] x86: suppress pointless f<op>p warnings

Jan Beulich JBeulich@suse.com
Wed Mar 7 12:38:00 GMT 2018


>>> On 07.03.18 at 13:32, <hjl.tools@gmail.com> wrote:
> On Wed, Mar 7, 2018 at 1:48 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> --- a/gas/config/tc-i386.c
>> +++ b/gas/config/tc-i386.c
>> @@ -6494,14 +6494,14 @@ duplicate:
>>             {
>>               /* Warn about some common errors, but press on regardless.
>>                  The first case can be generated by gcc (<= 2.8.1).  */
>> -             if (i.operands == 2)
>> +             if (i.operands == 2 && !i.op[0].regs->reg_type.bitfield.acc)
>>                 {
>>                   /* Reversed arguments on faddp, fsubp, etc.  */
>>                   as_warn (_("translating to `%s %s%s,%s%s'"), i.tm.name,
>>                            register_prefix, i.op[!intel_syntax].regs->reg_name,
>>                            register_prefix, i.op[intel_syntax].regs->reg_name);
>>                 }
>> -             else
>> +             else if (i.operands == 1)
>>                 {
>>                   /* Extraneous `l' suffix on fp insn.  */
>>                   as_warn (_("translating to `%s %s%s'"), i.tm.name,
> 
> Can we simply drop this encoding altogether?

Well, same here as for patch 1 of this series.

Jan



More information about the Binutils mailing list