opcodes error messages

[John Darrington]

On Sat, Mar 03, 2018 at 11:33:55AM +1030, Alan Modra wrote:
     Another patch aimed at making binutils comply with the GNU coding
     standard.  The generated files require
     https://sourceware.org/ml/cgen/2018-q1/msg00004.html
     
      /* -- opc.c */
     +#include "opintl.h"
      #include "elf/frv.h"
      #include <stdio.h>
      
     @@ -500,9 +501,9 @@ add_next_to_vliw (FRV_VLIW *vliw, CGEN_ATTR_VALUE_ENUM_TYPE unit)
      
        if (next <= 0)
          {
     -      fprintf (stderr, "frv-opc.c line %d: bad vliw->next_slot value.\n",
     -	       __LINE__);
     -      abort (); /* Should never happen.  */
     +      /* xgettext:c-format */
     +      opcodes_error_handler (_("internal error: bad vliw->next_slot value"));
     +      abort ();
          }

My interpretation of the GNU coding standards doesn't require that internal 
error messages be internationalised.  It's only required for messages which 
appear during normal operation, or in response to bad user input.

Of course that doesn't mean that they cannot be i18n'd if it isn't going to put
too much load on the translators.

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://sourceware.org/pipermail/binutils/attachments/20180303/ca5a1533/attachment.sig>