[committed] RISC-V: Accept constant operands in la and lla

[Sebastian Huber]

On 21/06/18 00:53, Palmer Dabbelt wrote:
> On Tue, 19 Jun 2018 22:27:25 PDT (-0700), 
> sebastian.huber@embedded-brains.de wrote:
>> opcodes/
>>     PR gas/23305
>>     * riscv-opc.c (riscv_opcodes): Use new format specifier 'B' for
>>     la and lla.
>>
>> gas/
>>     PR gas/23305
>>     * config/tc-riscv.c (riscv_ip): Add format specifier 'B' for
>>     constants and symbols.
>>     * testsuite/gas/riscv/lla32.d: New file.
>>     * testsuite/gas/riscv/lla32.s: Likewise.
>>     * testsuite/gas/riscv/lla64-fail.d: Likewise.
>>     * testsuite/gas/riscv/lla64-fail.l: Likewise.
>>     * testsuite/gas/riscv/lla64-fail.s: Likewise.
>>     * testsuite/gas/riscv/lla64.d: Likewise.
>>     * testsuite/gas/riscv/lla64.s: Likewise.
>> ---
>>  gas/ChangeLog                        | 13 +++++++++++++
>>  gas/config/tc-riscv.c                | 11 +++++++++++
>>  gas/testsuite/gas/riscv/lla32.d      | 19 +++++++++++++++++++
>>  gas/testsuite/gas/riscv/lla32.s      | 15 +++++++++++++++
>>  gas/testsuite/gas/riscv/lla64-fail.d |  3 +++
>>  gas/testsuite/gas/riscv/lla64-fail.l |  2 ++
>>  gas/testsuite/gas/riscv/lla64-fail.s |  3 +++
>>  gas/testsuite/gas/riscv/lla64.d      | 20 ++++++++++++++++++++
>>  gas/testsuite/gas/riscv/lla64.s      | 17 +++++++++++++++++
>>  opcodes/ChangeLog                    |  6 ++++++
>>  opcodes/riscv-opc.c                  |  4 ++--
>>  11 files changed, 111 insertions(+), 2 deletions(-)
>>  create mode 100644 gas/testsuite/gas/riscv/lla32.d
>>  create mode 100644 gas/testsuite/gas/riscv/lla32.s
>>  create mode 100644 gas/testsuite/gas/riscv/lla64-fail.d
>>  create mode 100644 gas/testsuite/gas/riscv/lla64-fail.l
>>  create mode 100644 gas/testsuite/gas/riscv/lla64-fail.s
>>  create mode 100644 gas/testsuite/gas/riscv/lla64.d
>>  create mode 100644 gas/testsuite/gas/riscv/lla64.s
>
> I'm not opposed to this, but did you check with a RISC-V maintainer 
> before committing it?  In general we try to keep our assembly syntax 
> compatible between the various assemblers, so any interface addition 
> should be discussed to make sure it's feasible everywhere. 

Sorry, I should have mentioned that this was pre-approved by Jim Wilson 
in the referenced PR:

https://sourceware.org/bugzilla/show_bug.cgi?id=23305

Which other assemblers are there to consider?

I try to add a documentation of "lla". See also:

https://groups.google.com/a/groups.riscv.org/forum/#!topic/sw-dev/sDQWmHyzHi8

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.