[committed] MIPS/ld/testsuite: Limit export class call reloc tests to DSO targets
Maciej W. Rozycki
macro@mips.com
Wed Jul 11 02:50:00 GMT 2018
Only run MIPS/LD export class call relocation tests with shared library
targets, avoiding:
.../ld/ld-new: -shared not supported
linker errors and removing:
FAIL: MIPS export class call relocation test (o32)
regressions with `mipsel-ps2-elf' and `mips64el-ps2-elf' targets.
ld/
* testsuite/ld-mips-elf/mips-elf.exp: Limit export class call
relocation tests to shared library targets.
---
ld/testsuite/ld-mips-elf/mips-elf.exp | 36 ++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
binutils-ld-mips-test-export-class-shared.diff
Index: binutils/ld/testsuite/ld-mips-elf/mips-elf.exp
===================================================================
--- binutils.orig/ld/testsuite/ld-mips-elf/mips-elf.exp 2018-07-09 12:56:34.000000000 +0100
+++ binutils/ld/testsuite/ld-mips-elf/mips-elf.exp 2018-07-09 13:03:34.273291678 +0100
@@ -1050,23 +1050,27 @@ run_dump_test "mips16-and-micromips"
# Export class call relocation tests.
set abis [concat o32 [expr {$has_newabi ? "n32 n64" : ""}]]
-foreach { abi } $abis {
- set loadaddr [string map \
- {o32 0x12340000 n32 0x12340000 n64 0x123456789abc0000} $abi]
- set suff [subst \
- [expr { $irix \
- ? [string map {o32 o32-irix n32 n32 n64 n64} $abi] \
- : $abi }]]
- run_ld_link_tests [list \
- [list \
- "MIPS export class call relocation test ($abi)" \
- "$abi_ldflags($abi) -shared -Ttext $loadaddr -T export-class-call16.ld" "" \
- "$abi_asflags($abi) -mips3 -KPIC" \
- [list export-class-call16-${abi}.s export-class-call16-def.s] \
+if [check_shared_lib_support] {
+ foreach { abi } $abis {
+ set loadaddr [string map \
+ {o32 0x12340000 n32 0x12340000 n64 0x123456789abc0000} $abi]
+ set suff [subst \
+ [expr { $irix \
+ ? [string map {o32 o32-irix n32 n32 n64 n64} $abi] \
+ : $abi }]]
+ run_ld_link_tests [list \
[list \
- "objdump -d export-class-call16-${suff}.dd" \
- "readelf -A export-class-call16-${abi}.gd"] \
- "export-class-call16-${abi}.so"]]
+ "MIPS export class call relocation test ($abi)" \
+ "$abi_ldflags($abi) -shared -Ttext $loadaddr\
+ -T export-class-call16.ld" \
+ "" \
+ "$abi_asflags($abi) -mips3 -KPIC" \
+ [list export-class-call16-${abi}.s export-class-call16-def.s] \
+ [list \
+ "objdump -d export-class-call16-${suff}.dd" \
+ "readelf -A export-class-call16-${abi}.gd"] \
+ "export-class-call16-${abi}.so"]]
+ }
}
# Magic __ehdr_start symbol tests.
More information about the Binutils
mailing list