[ARM] Fix warning cannot find thumb start symbol

Christophe Lyon christophe.lyon@linaro.org
Thu Jul 5 12:56:00 GMT 2018


Hi,

In case params.thumb_entry_symbol has its default NULL value, using it
to print a warning in gld${EMULATION_NAME}_finish results in a crash.

Use h->root.string instead which either points to
params.thumb_entry_symbol name or to entry_symbol name.

OK?

Thanks,

Christophe
-------------- next part --------------
2018-07-05  Christophe Lyon  <christophe.lyon@linaro.org>

	* emultempl/armelf.em (gld${EMULATION_NAME}_finish): Use the right
	symbol name in case of warning.

diff --git a/ld/emultempl/armelf.em b/ld/emultempl/armelf.em
index 2d98064..8ceceda 100644
--- a/ld/emultempl/armelf.em
+++ b/ld/emultempl/armelf.em
@@ -499,7 +499,7 @@ gld${EMULATION_NAME}_finish (void)
     }
   else
     einfo (_("%P: warning: cannot find thumb start symbol %s\n"),
-	   params.thumb_entry_symbol);
+	   h->root.string);
 }
 
 /* This is a convenient point to tell BFD about target specific flags.


More information about the Binutils mailing list