[PATCH] RISC-V: Support for FreeBSD

Jim Wilson jimw@sifive.com
Mon Jan 29 20:24:00 GMT 2018


On 01/29/2018 06:08 AM, Nick Clifton wrote:
> Hi Kito,
> 
>> This patch enable RISC-V support FreeBSD, Ruslan (RISC-V FreeBSD
>> maintainer) and me has been tested on FreeBSD 12 for building kernel
>> and whole user space programs/libraries.
> 
> Does this actually work ?
>   
>>     riscv*-*-*)			fmt=elf endian=little ;;
>> +  riscv*-*-freebsd*)			fmt=elf endian=little em=freebsd ;;
>   
> To me it looks like the first line will match "riscv-freebsd" as well,
> and since it has precedence the freebsd emulation parameter will not be
> set.

It does not work, for precisely the reason you mentioned.

It also appears pointless, as the only difference between te-generic.h 
and te-freebsd.h is the define of TE_FreeBSD in the latter, but that is 
not used anywhere in the RISC-V port.  So maybe that is why it "works", 
because it is unnecessary.  But that also means it is harmless and won't 
break anything if it goes in, with the order fixed of course.

I also don't see a copyright assignment for Ruslan.  This is probably OK 
as a trivial patches, but if there are more patches coming we would need 
a copyright assignment.

Jim



More information about the Binutils mailing list