[PATCH] [BFD] Fix override of COMMON symbols for a.out

Alan Modra amodra@gmail.com
Fri Jan 12 10:50:00 GMT 2018


On Thu, Jan 11, 2018 at 07:54:54PM +0100, gnikl@users.sourceforge.net wrote:
> 2018-01-12  Gunther Nikl  <gnikl@users.sourceforge.net>
> 
> 	* bfd/aoutx.h (aout_link_check_ar_symbols): Add
> 	  bfd_link_common_skip_none and make it the switch default.

Applied with a slight variation.

	* aoutx.h (aout_link_check_ar_symbols): Remove default and handle
	bfd_link_common_skip_none in switch.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 85ea86a..19364c0 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-12  Gunther Nikl  <gnikl@users.sourceforge.net>
+
+	* aoutx.h (aout_link_check_ar_symbols): Remove default and handle
+	bfd_link_common_skip_none in switch.
+
 2018-01-12  Alan Modra  <amodra@gmail.com>
 
 	PR ld/22649
diff --git a/bfd/aoutx.h b/bfd/aoutx.h
index 6dc4c68..eec9c4a 100644
--- a/bfd/aoutx.h
+++ b/bfd/aoutx.h
@@ -3366,13 +3366,14 @@ aout_link_check_ar_symbols (bfd *abfd,
 
 	      switch (info->common_skip_ar_symbols)
 		{
+		case bfd_link_common_skip_none:
+		  break;
 		case bfd_link_common_skip_text:
 		  skip = (type == (N_TEXT | N_EXT));
 		  break;
 		case bfd_link_common_skip_data:
 		  skip = (type == (N_DATA | N_EXT));
 		  break;
-		default:
 		case bfd_link_common_skip_all:
 		  skip = 1;
 		  break;

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list