[PATCH] strncpy -Wstringop-truncation in bfd/
Thu Feb 22 10:43:00 GMT 2018
On Wed, Feb 21, 2018 at 12:44:06PM -0800, John Reiser wrote:
> Several uses of strncpy in bfd/* do not compile when using -Werror in gcc 8.0.x
> because of -Wstringop-truncation. A typical warning is:
> ../../binutils-gdb/libiberty/dyn-string.c:280:3: warning: âstrncpyâ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
> A work-around is to use 'memcpy' instead of 'strncpy'. This spends
> a few more cycles each time; but it compiles, and runs correctly
> as long as the character arrays really are strings. Patch is attached.
But memcpy doesn't write zeros past the string terminator. If we're
writing to a file we want zeros rather than rubbish.
Australia Development Lab, IBM
More information about the Binutils