[binutils-gdb] Add .nop assembler directive

[H.J. Lu]

On Sun, Feb 18, 2018 at 8:50 PM, Alan Modra <amodra@gmail.com> wrote:
> On Sat, Feb 17, 2018 at 01:22:41PM -0000, H.J.Lu wrote:
>> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=62a02d25b6e5d9f92c205260daa11355d0c62532
>>
>> commit 62a02d25b6e5d9f92c205260daa11355d0c62532
>> Author: H.J. Lu <hjl.tools@gmail.com>
>> Date:   Sat Feb 17 05:20:42 2018 -0800
>>
>>     Add .nop assembler directive
>
> It looks like this patch caused the following regressions.  Please
> investigate.
>
> m68hc11-elf  +FAIL: objdump -WL
> m68hc11-elf  +FAIL: gas/elf/warn-2.s  (test for warnings, line )
> m68hc11-elf  +FAIL: lns-common-1
> m68hc11-elf  +FAIL: all_insns
> m68hc11-elf  +FAIL: 68HC12 indexed addressing mode with 5, 9 and 16-bit offsets (indexed12)
> m68hc11-elf  +FAIL: 68HC12 PC-relative addressing modes (bug-1825)
> m68hc11-elf  +FAIL: XGATE instruction set and all modes
> m68hc11-elf  +FAIL: ld-m68hc11/relax-group
> m68hc11-elf  +FAIL: ld-m68hc11/xgate1
> m68hc12-elf  +FAIL: objdump -WL
> m68hc12-elf  +FAIL: gas/elf/warn-2.s  (test for warnings, line )
> m68hc12-elf  +FAIL: lns-common-1
> m68hc12-elf  +FAIL: all_insns
> m68hc12-elf  +FAIL: 68HC12 indexed addressing mode with 5, 9 and 16-bit offsets (indexed12)
> m68hc12-elf  +FAIL: 68HC12 PC-relative addressing modes (bug-1825)
> m68hc12-elf  +FAIL: XGATE instruction set and all modes
> m68hc12-elf  +FAIL: ld-m68hc11/relax-group
> m68hc12-elf  +FAIL: ld-m68hc11/xgate1
> m68k-elf  +FAIL: MRI immediate constants
> m68k-linux  +FAIL: MRI immediate constants
> m68k-netbsd  +FAIL: MRI immediate constants
> spu-elf  +FAIL: objdump -WL
> spu-elf  +FAIL: gas/elf/warn-2.s  (test for warnings, line )
> spu-elf  +FAIL: lns-common-1
> spu-elf  +FAIL: ld-spu/icache1
> xgate-elf  +FAIL: objdump -WL
> xgate-elf  +FAIL: gas/elf/warn-2.s  (test for warnings, line )
> xgate-elf  +FAIL: lns-common-1
> xgate-elf  +FAIL: Dwarf2 test on insns.s
> xgate-elf  +FAIL: all_insns
> xgate-elf  +FAIL: insns
> z80-coff  +FAIL: relative jump out of range (jr)
> z80-coff  +FAIL: relative jump out of range (djnz)
> z80-coff  +FAIL: miscellaneous instructions
>

These are caused by

config/tc-m68hc11.h:#define NO_PSEUDO_DOT 1
config/tc-m68k.h:#define NO_PSEUDO_DOT 1
config/tc-spu.h:#define NO_PSEUDO_DOT 1
config/tc-xgate.h:#define NO_PSEUDO_DOT 1
config/tc-xtensa.c:/* NO_PSEUDO_DOT hook */
config/tc-xtensa.h:#define NO_PSEUDO_DOT        xtensa_check_inside_bundle ()
config/tc-z80.h:#define NO_PSEUDO_DOT                1

We match  .nop diretive to nop instruction.  This patch avoids
matching .nop diretive to nop instruction when NO_PSEUDO_DOT
is defined to 1.   OK for master?

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Avoid-matching-.nop-diretive-to-nop-instruction.patch
Type: text/x-patch
Size: 1750 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20180219/2af59139/attachment.bin>