[PATCH] x86: Add .nop directive to assembler

H.J. Lu hjl.tools@gmail.com
Fri Feb 16 14:34:00 GMT 2018


On Fri, Feb 16, 2018 at 5:58 AM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Thu, 15 Feb 2018, H.J. Lu wrote:
>
>> OK for master?
>
> @@ -4523,6 +4523,7 @@ Some machine configurations provide additional directives.
>  * Sleb128::                    @code{.sleb128 @var{expressions}}
>  @ifclear no-space-dir
>  * Space::                       @code{.space @var{size} , @var{fill}}
> +* Nop::                         @code{.nop @var{size}[, @var{limit}]}
>  @end ifclear
>  @ifset have-stabs
>  * Stab::                        @code{.stabd, .stabn, .stabs}
>
> You probably don't want to have the Nop entry conditional on no-space-dir.
> The index is also supposed to be sorted alphabetical.  And the description
> of above item still says "limit" instead of "control".
>
> @@ -450,14 +453,18 @@ cvt_frag_to_fill (segT sec ATTRIBUTE_UNUSED, fragS *fragP)
>        if (fragP->fr_offset < 0)
>         {
>           as_bad_where (fragP->fr_file, fragP->fr_line,
> -                       _("attempt to .org/.space backwards? (%ld)"),
> +                       _("attempt to .org/.space/,nop backwards? (%ld)"),
>
> ".nop", not ",nop".
>

All fixed.  Here is the updated patch.  OK for master?


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-.nop-assembler-directive.patch
Type: text/x-patch
Size: 42753 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20180216/83af545a/attachment.bin>


More information about the Binutils mailing list