[PATCH] x86: Remove the unused _GLOBAL_OFFSET_TABLE_

H.J. Lu hjl.tools@gmail.com
Thu Feb 8 21:57:00 GMT 2018


On Mon, Feb 5, 2018 at 8:37 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Feb 4, 2018 at 8:26 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Since _GLOBAL_OFFSET_TABLE_ may be referenced implicitly on x86,
>> checking ref_regular_nonweak leaves the unused _GLOBAL_OFFSET_TABLE_
>> in output.  This patch checks explicit GOT references instead.
>>
>> bfd/
>>
>>         PR ld/22782
>>         * elf32-i386.c (elf_i386_check_relocs): Set got_referenced if
>>         GOT is referenced.
>>         * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
>>         * elfxx-x86.c (_bfd_x86_elf_size_dynamic_sections): Likewise.
>>         Check got_referenced instead of ref_regular_nonweak.  Remove
>>         the unused _GLOBAL_OFFSET_TABLE_ from symbol table.
>>         * elfxx-x86.h (elf_x86_link_hash_table): Add got_referenced.
>>
>> ld/
>>
>>         PR ld/22782
>>         * testsuite/ld-i386/discarded1.s: Replace mov with div.
>>         * testsuite/ld-x86-64/discarded1.s: Likewise.
>>         * testsuite/ld-i386/i386.exp: Run pr22782.
>>         * testsuite/ld-i386/load1-nacl.d: Updated for removing
>>         _GLOBAL_OFFSET_TABLE_ from output.
>>         * testsuite/ld-i386/load1.d: Likewise.
>>         * testsuite/ld-x86-64/load1a-nacl.d: Likewise.
>>         * testsuite/ld-x86-64/load1a.d: Likewise.
>>         * testsuite/ld-x86-64/load1b-nacl.d: Likewise.
>>         * testsuite/ld-x86-64/load1b.d: Likewise.
>>         * testsuite/ld-i386/pr22782.d: New file.
>>         * testsuite/ld-i386/pr22782.s: Likewise.
>>         * testsuite/ld-x86-64/pr22782.s: Likewise.
>>         * testsuite/ld-x86-64/pr22782a.d: Likewise.
>>         * testsuite/ld-x86-64/pr22782b.d: Likewise.
>>         * testsuite/ld-x86-64/x86-64.exp: Run pr22782a and pr22782b.
>
> This is the patch I am checking in.
>

Solaris requires to keep _GLOBAL_OFFSET_TABLE_ even if it isn't used.
I checked in this patch to detect Solaris target and keeps it for Solaris.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-Keep-the-unused-_GLOBAL_OFFSET_TABLE_-for-Solari.patch
Type: text/x-patch
Size: 5924 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20180208/f082b17b/attachment.bin>


More information about the Binutils mailing list