[PATCH 1/3] binutils/testsuite: Support stderr options with `run_dump_test'

Pip Cet pipcet@gmail.com
Sun Feb 4 15:09:00 GMT 2018


Hello Maciej,

On Fri, Feb 2, 2018 at 5:22 PM, Maciej W. Rozycki <macro@mips.com> wrote:
>  Apparently with `testsuite/binutils-all/wasm32/invalid-wasm-1.d' someone
> has already tried to use `error', figured out support was missing and
> disabled the test rather than adding such support.

I believe I added support for it but never submitted the change;
obviously it's a moot point now you've added support in a slightly
different way.

> Interestingly this
> test, unusually, expects an error in the dumper tool to be handled rather
> than one in the tool under test, which is unlike the GAS and LD test
> frameworks work, and unlike the binutils framework will with this change
> in place.

Thanks for the observation. I agree, and I shall hopefully get around
to changing it to conform to the new syntax (I've just started a new
job and this might take a while).

>  NB source for `testsuite/binutils-all/wasm32/invalid-wasm-2.d' is
> additionally missing.

I don't understand. Both invalid-wasm-2.d and invalid-wasm-2.s are in
a fresh git checkout, and I don't see any other sources being used. Am
I missing something?

Thanks,
Pip



More information about the Binutils mailing list