[PATCH] gold: Provide more failed archive member info in error message

Cary Coutant ccoutant@gmail.com
Tue Dec 4 08:01:00 GMT 2018


> +  bool plugin_failed = false;
>
>    if (is_elf_object(input_file, memoff, &ehdr, &read_size))
>      {
> @@ -716,12 +717,20 @@ Archive::get_elf_object_for_member(off_t off, bool* punconfigured)
>             delete obj;
>            return plugin_obj;
>          }
> +
> +      plugin_failed = true;

An unclaimed file is not a plugin "failure". I'd prefer to name this
variable "unclaimed".

-cary



More information about the Binutils mailing list