[PATCH 0/6] MIPS reorganize the loongson march and extensions instructions set

Paul Hua paul.hua.gm@gmail.com
Sat Aug 18 08:28:00 GMT 2018


Hi Nick,

Thanks for your review.

> The patches themselves are fine, but there is one problem - you
> need to update the gold linker as well.  This still has references
> to the deprecated Loongson3a name and no code for the gs464e or gs264
> variants...

The new patch will update gold linker.

> Also, with the patches applied I did find a few regressions in some
> of the binutils test suites:
>
> Checking Binutils in: mips64-openbsd ...
>   LD REGRESSION: MIPS incompatible objects: "-march=gs464 -32"
>   LD REGRESSION: MIPS compatible objects: "-march=gs464 -32"
>   LD REGRESSION: MIPS compatible objects: "-march=gs264e -32"
>
> Checking Binutils in: mips64el-openbsd ...
>   LD REGRESSION: MIPS incompatible objects: "-march=gs464 -32"
>   LD REGRESSION: MIPS compatible objects: "-march=gs464 -32"
>   LD REGRESSION: MIPS compatible objects: "-march=gs264e -32"
>
> Checking Binutils in: mips-sgi-irix6 ...
>   LD REGRESSION: MIPS compatible objects: "-march=gs464 -32"
>   LD REGRESSION: MIPS compatible objects: "-march=gs264e -32"
>
> Checking Binutils in: mipsisa32el-linux ...
>   GAS REGRESSION: Loongson CAM tests
>   GAS REGRESSION: Loongson EXT2 tests
>
> Checking Binutils in: tx39-elf ...
>   GAS REGRESSION: Loongson CAM tests
>   GAS REGRESSION: Loongson EXT2 tests
>
>
> Would you mind taking a look at these please ?  I suspect that they
> will just turn out to be cases where it is inappropriate to run the
> test, but I would like to be sure.

I will look at these tests, is there a script or document for test all
of these triples.
I just configure with --target=mips64el-linux-gnu and make, make
check, no regression.

> Cheers
>   Nick
>
> PS. Are you able to comit patches yourself, or do you need me to do that ?

I would like to commit patches myself, but not have write access yet,
how to get write access?

Paul Hua



More information about the Binutils mailing list