AW: Software Quality Binutils

[John Darrington]

On Thu, Aug 16, 2018 at 04:18:47PM +0000, Christoph Hazott wrote:
     Hi Jeff,
     
     yes of course! Do you have any suggestions?
     
     Regards,
     
     Christoph

Just out of curiosity I quickly ran cppchack on the bfd directory (since
that's rather central to a lot of things), filtered out a few uninteresting cases and 
got the result:


[bfd/cpu-sh.c:468]: (error) Shifting 32-bit value by 32 bits is undefined behaviour
[bfd/elf32-ppc.c:7944]: (error) Signed integer overflow for expression '2172846080+4'.
[bfd/elf32-ppc.c:11404]: (error) Signed integer overflow for expression '2173435904+4'.
[bfd/elf32-ppc.c:11431]: (error) Signed integer overflow for expression '2173435904+4'.
[bfd/elf32-rl78.c:476]: (error) Division by zero.
[bfd/elf32-rl78.c:532]: (error) Division by zero.
[bfd/elf32-sh.c:6002]: (error) Shifting 32-bit value by 32 bits is undefined behaviour
[bfd/elf32-sh.c:6014]: (error) Shifting 32-bit value by 32 bits is undefined behaviour
[bfd/elf64-alpha.c:5041]: (error) Shifting a negative value is undefined behaviour
[bfd/elf64-ppc.c:6942]: (error) Signed integer overflow for expression '4160815104+16'.
[bfd/elf64-ppc.c:6958]: (error) Signed integer overflow for expression '3892379648+16'.
[bfd/elf64-ppc.c:7013]: (error) Signed integer overflow for expression '4160815104+16'.
[bfd/elf64-ppc.c:7029]: (error) Signed integer overflow for expression '3892379648+16'.
[bfd/elf64-ppc.c:11319]: (error) Signed integer overflow for expression '3915579392+0'.
[bfd/elf64-ppc.c:11320]: (error) Signed integer overflow for expression '3917676544+8'.
[bfd/elf64-ppc.c:14216]: (error) Signed integer overflow for expression '4165009408+24'.
[bfd/gen-aout.c:54]: (error) Resource leak: file
[bfd/mach-o.c:5582]: (error) Signed integer overflow for expression '3221225472-67108864'.
[bfd/mmo.c:497]: (error) Buffer is accessed out of bounds: valid_mmo_symbol_character_set
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_5_CORE;AIX_CORE'.
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_5_CORE;HAVE_ST_C_IMPL;AIX_CORE'.
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_CORE'.
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_CORE;AOUTHDR'.
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_CORE;BFD64'.
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_CORE;BFD64;CORE_VERSION_1'.
[bfd/rs6000-core.c:311]: (error) Invalid number of character '(' when these macros are defined: 'AIX_CORE;CORE_VERSION_1'.


Some of those seem a little concerning at first glance  ...

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.