[PATCH 1/2] gas/as.c: print input and output details when error

[Rainer Orth]

Hi Robert,

> On 08/09/2018 05:22 PM, Andreas Schwab wrote:
>> On Aug 09 2018, Robert Yang <liezhi.yang@windriver.com> wrote:
>>
>>> as_fatal (_("The input '%s' and output '%s' have the same inode %ld"),
>>>             argv[i],  sib.st_ino, saved_out_file_name))
>>
>> st_ino is an opaque, filesystem internal number.  I have a hard time
>> figuring out why it would ever be useful to know.  Also, the correct
>> format to print it is very platform dependent, and likely incompatible
>> with %ld.
>
> Yes, I just realized that binutils maybe used on other platforms, so I
> will avoid print that. Only print:
>
> "The input '%s' and output '%s' have the same inode"

even the concept of inode is Unix-specific.  POSIX.1 talks of `file
serial number'.  Best to avoid this in user-facing messages since it's
just an irrelevant implementation detail, maybe say `... are the same
file' or some such?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University